Go fast Fix #358
Draft
Go fast Fix #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the test failures showed me there are still a couple things left to figure out before this can be merged. I might consider splitting this PR into the easy fixes around Docker and the install script and the more involved |
HPPinata
force-pushed
the
go-fast-fix
branch
2 times, most recently
from
c2d2387
to
b1ba5c1
Compare
Merged
HPPinata
force-pushed
the
go-fast-fix
branch
from
b1ba5c1
to
6d433b5
Compare
HPPinata
force-pushed
the
go-fast-fix
branch
from
6d433b5
to
f3c713c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes flash_attn a bit more flexible in regards to the head dimensions, etc. supported.
Reference Beinsezii/comfyui-amd-go-fast#3.
Also make sure the Docker container doesn't exit when doing an
rmof a non existant file.This shouldn't change existing behaviour (apart from the docker fix).