Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support additional arguments, required for ActiveRecord 7.1 #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomdev
Copy link
Member

@tomdev tomdev commented Jun 5, 2024

When using arel_toolkit v0.6.0 I'm running into the following error when used in a Rails 7.1 application (which is using active_record 7.1.3.3):

ArgumentError: unknown keywords: :allow_retry, :materialize_transactions (ArgumentError)
/app/lib/app_name/protected_attribute/connection_helpers.rb:114:in `configure_connection'

In active_record 7.1 the exec_no_cache and exec_cache methods require the keywords :allow_retry and :materialize_transactions. arel_toolkit was not passing these arguments.

This PR passes any additional arguments passed in to the super call to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant