rubocop: run safe linters

Hacker0x01 · Mar 29, 2023 · 85ebd2c · 85ebd2c
1 parent ae0bac8
commit 85ebd2c
Show file tree

Hide file tree

Showing 95 changed files with 40 additions and 272 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
     - 'gemfiles/arel_gems.gemfile'
     - 'gemfiles/default.gemfile'
     - 'vendor/bundle/**/*'
-
+  SuggestExtensions: false
 
 Bundler/OrderedGems:
   Enabled: false

diff --git a/Guardfile b/Guardfile
@@ -15,7 +15,7 @@
 #
 # and, you'll have to watch "config/Guardfile" instead of "Guardfile"
 
-# Note: The cmd option is now required due to the increasing number of ways
+# NOTE: The cmd option is now required due to the increasing number of ways
 #       rspec may be run, below are examples of the most common uses.
 #  * bundler: 'bundle exec rspec'
 #  * bundler binstubs: 'bin/rspec'

diff --git a/lib/arel/enhance/node.rb b/lib/arel/enhance/node.rb
@@ -1,10 +1,7 @@
 module Arel
   module Enhance
     class Node
-      attr_reader :local_path
-      attr_reader :object
-      attr_reader :parent
-      attr_reader :root_node
+      attr_reader :local_path, :object, :parent, :root_node
 
       def initialize(object)
         @object = object
@@ -126,9 +123,7 @@ def context
 
       protected
 
-      attr_writer :local_path
-      attr_writer :parent
-      attr_writer :root_node
+      attr_writer :local_path, :parent, :root_node
 
       # rubocop:disable Metrics/AbcSize
       # rubocop:disable Metrics/CyclomaticComplexity

diff --git a/lib/arel/enhance/path_node.rb b/lib/arel/enhance/path_node.rb
@@ -1,8 +1,7 @@
 module Arel
   module Enhance
     class PathNode
-      attr_reader :method
-      attr_reader :value
+      attr_reader :method, :value
 
       def initialize(method, value)
         @method = method

diff --git a/lib/arel/extensions/active_model_attribute_with_cast_value.rb b/lib/arel/extensions/active_model_attribute_with_cast_value.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Visitors
@@ -19,4 +18,3 @@ def visit_ActiveModel_Attribute_WithCastValue(_o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/active_record_relation_query_attribute.rb b/lib/arel/extensions/active_record_relation_query_attribute.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Visitors
@@ -19,4 +18,3 @@ def visit_ActiveRecord_Relation_QueryAttribute(_o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/all.rb b/lib/arel/extensions/all.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -20,4 +19,3 @@ def visit_Arel_Nodes_All(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/any.rb b/lib/arel/extensions/any.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -20,4 +19,3 @@ def visit_Arel_Nodes_Any(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/array.rb b/lib/arel/extensions/array.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -19,4 +18,3 @@ def visit_Arel_Nodes_Array(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/array_subselect.rb b/lib/arel/extensions/array_subselect.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -20,4 +19,3 @@ def visit_Arel_Nodes_ArraySubselect(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/assignment.rb b/lib/arel/extensions/assignment.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 module Arel
   module Visitors
     class ToSql
@@ -19,4 +18,3 @@ def visit_Arel_Nodes_Assignment(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/at_time_zone.rb b/lib/arel/extensions/at_time_zone.rb
@@ -1,12 +1,10 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
     # https://www.postgresql.org/docs/9.2/functions-datetime.html#FUNCTIONS-DATETIME-ZONECONVERT
     class AtTimeZone < Arel::Nodes::Node
-      attr_reader :timezone
-      attr_reader :expr
+      attr_reader :timezone, :expr
 
       def initialize(expr, timezone)
         @expr = expr
@@ -34,4 +32,3 @@ def visit_Arel_Nodes_AtTimeZone(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/attributes_attribute.rb b/lib/arel/extensions/attributes_attribute.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Attributes
@@ -44,4 +43,3 @@ def visit_Arel_Attributes_Attribute(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/between_symmetric.rb b/lib/arel/extensions/between_symmetric.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -20,4 +19,3 @@ def visit_Arel_Nodes_BetweenSymmetric(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/bind_param.rb b/lib/arel/extensions/bind_param.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Visitors
@@ -12,4 +11,3 @@ def visit_Arel_Nodes_BindParam(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/bit_string.rb b/lib/arel/extensions/bit_string.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -17,4 +16,3 @@ def visit_Arel_Nodes_BitString(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/case.rb b/lib/arel/extensions/case.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Visitors
@@ -14,4 +13,3 @@ def visit_Arel_Nodes_Case(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/coalesce.rb b/lib/arel/extensions/coalesce.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -20,4 +19,3 @@ def visit_Arel_Nodes_Coalesce(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/conflict.rb b/lib/arel/extensions/conflict.rb
@@ -1,14 +1,10 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
     # https://www.postgresql.org/docs/9.5/sql-insert.html
     class Conflict < Arel::Nodes::Node
-      attr_accessor :action
-      attr_accessor :infer
-      attr_accessor :values
-      attr_accessor :wheres
+      attr_accessor :action, :infer, :values, :wheres
     end
   end
 
@@ -53,4 +49,3 @@ def visit_Arel_Nodes_Conflict(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/contains.rb b/lib/arel/extensions/contains.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   if Gem.loaded_specs.key?('postgres_ext')
@@ -29,4 +28,3 @@ def initialize(left, right)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/cross_join.rb b/lib/arel/extensions/cross_join.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -18,4 +17,3 @@ def visit_Arel_Nodes_CrossJoin(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_catalog.rb b/lib/arel/extensions/current_catalog.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -21,4 +20,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_date.rb b/lib/arel/extensions/current_date.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -21,4 +20,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_of_expression.rb b/lib/arel/extensions/current_of_expression.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -19,4 +18,3 @@ def visit_Arel_Nodes_CurrentOfExpression(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_role.rb b/lib/arel/extensions/current_role.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -21,4 +20,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_schema.rb b/lib/arel/extensions/current_schema.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -21,4 +20,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_time.rb b/lib/arel/extensions/current_time.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -19,4 +18,3 @@ def visit_Arel_Nodes_CurrentTime(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_timestamp.rb b/lib/arel/extensions/current_timestamp.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -19,4 +18,3 @@ def visit_Arel_Nodes_CurrentTimestamp(o, collector)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/current_user.rb b/lib/arel/extensions/current_user.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -21,4 +20,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/dealocate.rb b/lib/arel/extensions/dealocate.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Visitors
@@ -28,4 +27,3 @@ def initialize(name)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/default_values.rb b/lib/arel/extensions/default_values.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
@@ -22,4 +21,3 @@ class Dot
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/delete_manager.rb b/lib/arel/extensions/delete_manager.rb
@@ -1,5 +1,4 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   class DeleteManager < Arel::TreeManager
@@ -22,4 +21,3 @@ def visit_Arel_DeleteManager(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName
diff --git a/lib/arel/extensions/delete_statement.rb b/lib/arel/extensions/delete_statement.rb
@@ -1,15 +1,11 @@
 # rubocop:disable Naming/MethodName
-# rubocop:disable Naming/UncommunicativeMethodParamName
 
 module Arel
   module Nodes
     # https://www.postgresql.org/docs/10/sql-delete.html
     class DeleteStatement
       module DeleteStatementExtension
-        attr_accessor :using
-        attr_accessor :with
-        attr_accessor :returning
-        attr_accessor :orders
+        attr_accessor :using, :with, :returning, :orders
 
         def initialize(relation = nil, wheres = [])
           super
@@ -75,4 +71,3 @@ def visit_Arel_Nodes_DeleteStatement(o)
 end
 
 # rubocop:enable Naming/MethodName
-# rubocop:enable Naming/UncommunicativeMethodParamName