Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/header footer #8

Merged
merged 8 commits into from
Nov 18, 2024
Merged

Feat/header footer #8

merged 8 commits into from
Nov 18, 2024

Conversation

ReehalS
Copy link
Member

@ReehalS ReehalS commented Nov 17, 2024 •
edited
Loading

For Closing #6
Current issues I am aware of:

  • Icons in footer have changed since last year
  • Font family of "Plus Jakarta Sans" looks very different compared to what is on the Figma (the default font looks more similar, so thats what I left it as)
  • Design may want to change the translucent light bluish grey color I've chosen for the navbar background on scroll.

Placeholders:

  • Bright Blue background in initial state will be removed in feat/Hero-Background

@ReehalS ReehalS marked this pull request as draft November 17, 2024 03:20
@ReehalS ReehalS requested a review from JayJ104 November 17, 2024 03:20
@ReehalS ReehalS linked an issue Nov 17, 2024 that may be closed by this pull request
ui: navbar and footer #6
Closed
@ReehalS ReehalS requested a review from winzamark123 November 17, 2024 03:50
@ReehalS ReehalS marked this pull request as ready for review November 17, 2024 03:50
@ReehalS
Copy link
Member Author

ReehalS commented Nov 17, 2024

All the extra files changed were to pass Linting checks

winzamark123
winzamark123 reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@winzamark123 winzamark123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naisu

@winzamark123 winzamark123 merged commit 4c105c9 into main Nov 18, 2024
2 checks passed
@winzamark123 winzamark123 deleted the feat/HeaderFooter branch November 18, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winzamark123 winzamark123 winzamark123 left review comments

@JayJ104 JayJ104 Awaiting requested review from JayJ104

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: navbar and footer
2 participants
@ReehalS @winzamark123