Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features page html css #28

Closed
wants to merge 9 commits into from
Closed

Features page html css #28

wants to merge 9 commits into from

Conversation

renjani2022
Copy link
Collaborator

@renjani2022 renjani2022 commented Aug 5, 2022

General Checks

  • the branch is up to date with main/master
  • the code works when pulled and run locally
  • All CI checks pass
  • all conflicts are resolved (if any)
  • PR has a descriptive title
  • PR has appropriate labels and milestones for easy identification
  • PR it is assigned to the owner
  • reviewers are assigned
  • the PR contributes only one focused change
  • It is in the appropriate column in the project board (if necessary)
  • has short and clear description
  • is linked to an issue (if it is related)
  • feedback is addressed (if any and if it is appropriate feedback.)

Markdown

  • the markdown source is formatted
  • spelling and grammar is correct in all text
  • The markdown looks correct when you preview the file
  • all links and images work

HTML

  • pages besides /index.html are stored in /pages
  • the code is well-formatted
  • the HTML is valid
  • there are no inline styles (example: style='color: red;')
  • there are no <style> tags with CSS, all styles are hrefs
  • there is no inline JavaScript (example: onclick='doSomething()')
  • there are no <script> tags with JS, all JS is in an separate file
  • ids are used for JavaScript only, not for CSS
  • semantic tags are used
  • spelling and grammar is correct in all site content

CSS

  • the code is well-formatted
  • passes all the linting checks

renjani2022 and others added 6 commits August 5, 2022 15:39
Add one new ligne in new file. It's   "editor.renderIndentGuides": true," line.
This ligne is inside the old file and not in the "push" file.
Try to solve the problem mentioned by the attached screenshot (in DropBox URL below)  by cutting the /*Docs*/ heading and pasting it before the /*Stats*/ heading in the "features-css/style.css" file.
https://www.dropbox.com/s/uysxezsc07d5x06/Features-page-html-css-%C2%B7-HYF-Class19-agile-development-loruki-group-2-a8dfb71.png?dl=0
Copy link
Collaborator

@thomas-ayissi thomas-ayissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to solve some tests issues by make some changes directly in "features-css/style.css" file.
So @renjani2022 try to make the process that i send you by Slack Direct Messages. Take Care

This was linked to issues Aug 5, 2022
@thomas-ayissi thomas-ayissi self-requested a review August 5, 2022 16:04
Copy link
Collaborator

@thomas-ayissi thomas-ayissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see previous and message in this pull request :-)

@renjani2022 renjani2022 linked an issue Aug 5, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Features Page: html, css Features page - HTML Features page - CSS
2 participants