Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new QC metrics covering DIA-NN output #333

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

cbielow
Copy link
Contributor

@cbielow cbielow commented Sep 18, 2024

distilled from HUPO-PSI/mzQC#244

(version number assumes #330 to be merged)

psi-ms.obo Outdated Show resolved Hide resolved
psi-ms.obo Outdated Show resolved Hide resolved
psi-ms.obo Show resolved Hide resolved
psi-ms.obo Show resolved Hide resolved
psi-ms.obo Outdated Show resolved Hide resolved
psi-ms.obo Outdated Show resolved Hide resolved
psi-ms.obo Show resolved Hide resolved
psi-ms.obo Show resolved Hide resolved
psi-ms.obo Show resolved Hide resolved
@cbielow
Copy link
Contributor Author

cbielow commented Sep 23, 2024

thanks for the review @bittremieux :)
I've incorporated the suggestions and left a comment on the open questions.

This looks almost good to go IMHO.

@mobiusklein mobiusklein added this pull request to the merge queue Oct 4, 2024
Merged via the queue into HUPO-PSI:master with commit 3f7c327 Oct 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants