Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feb 2021 Error Fixes and New Mods #56

Merged
merged 21 commits into from
Mar 10, 2021
Merged

Feb 2021 Error Fixes and New Mods #56

merged 21 commits into from
Mar 10, 2021

Conversation

pmt706
Copy link
Member

@pmt706 pmt706 commented Mar 3, 2021

  • Fixed several errors found in PSI-MOD.
  • Using a list from Emanuele Alpi, I'm systematically adding in curated PTMs tied to known protein modifications in UniProtKB
  • Updated the readme.md to fix a couple of typos and add in procedures for editing PSI-MOD.
  • Created a valid OWL to accompany the update OBO

Changes relationship between MOD:01914 and the glycosylation tree.  The difference in mass is due to two modifications, hydroxylation and galactosylation.
Updates text on README and adds in OWL information
New PTM Described in UniProt
Per UniProt
Adding Connection to UniProt
There was an error in MOD:00241 hydroxymethyl asparagine is not glycosyl asparagine
Copy link
Contributor

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks!

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

galactosylation (and in general glycosylation) of hydroxylysine is a mod that occurs post translationally to a hydroxylysine in collagene. The is_a tag should somehow remain, as the modified residue is here a hydroxylysine (similarly to is_a =-glycosilated residue). As far as I know, a residue is not exclusively limited to the 20 classical AAs in PSI-MOD (at least not formally)

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please maka a precision that the obo file is the master source, and that the OWL is a derivative of it.

@ricardblum
Copy link

I agree with Pierre-Alain's comment on the galactosylation of hydroxylysine residues.

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mod is not a crosslink, therefore please adapt the definition : replace by.
A protein modification that effectively modifies an L-serine residue with 5'-phosphouridine through a phosphodiester bond ...

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous comment valid for both MODs

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, its a modification of and not a crosslink. Please change the def accordingly:
A protein modification that effectively modifies an L-serine residue with 5'-phosphoadenosine through a phosphodiester bond

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PTM is obtained by a mod by itaconate. Might be interesting to mention this in the def:
A protein modification that effectively converts an L-cysteine residue to form S-methylbutanedioic acid-L-cysteine through by alkylation with itaconate through a thioether bond." [PubMed:29590092]

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the mod
DiffFormula: "C 4 H 6 N 0 O 2" (and not H7?)

Maybe PTMlist is also wrong...

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove:
is_a: MOD:00203 ! D-asparagine

You can create a mod for modified D-asparagine residue, which is related to D-asparagine (and parent of this mod and the current child crosslinked D-asparagine residue entry)

In this case one can also create all D-residues as unnatural forms (to be discussed)

pabinz
pabinz previously requested changes Mar 4, 2021
Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you doublecheck the following block:
xref: Formula: "C 24 H 40 N 1 O 2 S 1"
xref: MassAvg: "406.65"
xref: MassMono: "406.277976"

to me it seems that there is one O too much. Compared to MOD_00113 (S-geranylgeranyl-L-cysteine) there should be only a H to CH3 change ; the methyl ester comes from the fact that it is a methylation of a carboxyl group, therefore yieldig a methyl ester moiety.
The formula should be
xref: Formula: "C 24 H 40 N 1 O 21 S 1".
The trick is that for all peptides/protein, one should add H2O to all ftotal formulae in order to get the final product in a neutral form. Here the C-term is only replacing a H for a CH3, no O involved...

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, revert my previous comment: When C-term is specified, the +H2O rule should not apply and is to be replaced by +H (N-term) and consider the Formula, MassAvg and MassMono as replacing the C-term default OH by NULL and consider only the Formula, MassAvg and MassMono as being the summ of the modified residue + the Cterm moiety.

However, this property and behavior should be specified in the beginning of the file.

@pabinz
Copy link
Contributor

pabinz commented Mar 4, 2021 via email

@pmt706
Copy link
Member Author

pmt706 commented Mar 8, 2021 via email

Fixing syntax error in MOD:01080, fixes HUPO-PSI#57
Removed:
is_a: MOD:00203 ! D-asparagine

Created a mod for modified D-asparagine residue (MOD:02097), which is_a D-asparagine (and parent of MOD:002097, this mod and the current child crosslinked D-asparagine residue entry, MOD:02060)

We need to rehome the D-residues, but to be discussed later
@pabinz is correct, PTMList (PTM-0499) is wrong.  I will contact them to correct!
Updated def to include additional information from @pabinz
replaced crosslink language with modification language
@pmt706 pmt706 dismissed pabinz’s stale review March 10, 2021 15:07

per his request in the next comment!

@pmt706
Copy link
Member Author

pmt706 commented Mar 10, 2021

@pabinz, @ricardblum For MOD:01914, the issue that removed the is_a for monogalactosylated residue is the difference in mass between this mod, MOD:01914 at ~178 Da and MOD:00476 at 162 Da (differing by the oxygen that makes it hydroxylysine). This isn't allowed. If modA has a diffmass of "X" AND if modA is_a: modB, then it follows that modB's diffmass MUST also be "X".

Since it's known that the modification is to hydroxylysine and not to lysine, I'm going to change the origin on MOD:01914 from K to MOD:00037 (5-hydroxy-L-lysine). This will change the diffMass to 162 and fulfill the obligation above.

Fixes MOD:01914 as described in the PR comment. The collagen mods need a bit of massaging in the future.
@pmt706 pmt706 merged commit 54b48ef into HUPO-PSI:master Mar 10, 2021
@pmt706 pmt706 deleted the Feb2021 branch March 10, 2021 15:25
PSI-MOD.obo Show resolved Hide resolved
Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thx

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thx

Copy link
Contributor

@pabinz pabinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants