Update the default plotting style #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks @amete 😄
@graeme-a-stewart sorry to pester but could you tag a release with this so it can be picked up by conda-forge?
|
I exceptionally self-merged this PR since it's a rather straightforward change that is needed by LHCb. |
|
@chrisburr, we just released a new tag/release @ https://github.com/HSF/prmon/releases/tag/v3.1.1. It probably should've been a new minor release instead of a patch but that practically doesn't make much difference. Let us know how this looks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like
matplotlibrenamed the built-in (and outdated)seabornstyles (see matplotlib/pull/22317) in the newer releases. With this PR, the plotting script first checks if the style equivalent to what we were using exists and if so we use it. Otherwise we don't do anything special.Closes #244