Skip to content

Commit

Permalink
Merge pull request #101 from kbseah/master
Browse files Browse the repository at this point in the history
Change wildcard for download path of SILVA database
  • Loading branch information
HRGV authored Jan 8, 2020
2 parents 4684823 + f087306 commit 4496ff4
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 13 deletions.
2 changes: 1 addition & 1 deletion PhyloFlash.pm
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ This module contains helper functions shared by the phyloFlash scripts.
=cut

our $VERSION = "3.3b1";
our $VERSION = "3.3b2";
our @ISA = qw(Exporter);
our @EXPORT = qw(
$VERSION
Expand Down
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<img align="right" src="docs/phyloFlash_logo.png" width="200" alt="phyloFlash logo"/>

# phyloFlash v3.3 beta 1
# phyloFlash v3.3b2

[![GitHub (pre-)release](https://img.shields.io/github/release/HRGV/phyloflash/all.svg?label=Latest%20Version)]()
[![Bioconda](https://img.shields.io/conda/vn/Bioconda/phyloFlash.svg)](https://bioconda.github.io/recipes/phyloflash/README.html)
Expand Down Expand Up @@ -42,11 +42,11 @@ If you clone the repository directly off GitHub you might end up with a version

```bash
# Download latest release
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
tar -xzf pf3.3b1.tar.gz
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
tar -xzf pf3.3b2.tar.gz

# Check for dependencies and install them if necessary
cd phyloFlash-pf3.3b1
cd phyloFlash-pf3.3b2
./phyloFlash.pl -check_env
```

Expand Down Expand Up @@ -113,6 +113,9 @@ For further information **please refer to the [Manual](https://hrgv.github.io/ph

## Versions and changes

* v3.3 beta 2
* New options to graphical comparison scripts, and other small bug fixes
* Fix bug due to change in SILVA project file naming convention with SILVA 138 onwards
* v3.3 beta 1
* Add support for using SortMeRNA instead of BBmap for initial mapping step
* Changes to how mapping data are hashed; process SAM file of initial mapping to fix known bugs with bitflag and read name reporting in BBmap and SortMeRNA
Expand Down
6 changes: 3 additions & 3 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ If you clone the repository directly off GitHub you might end up with a version

```bash
# Download latest release
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
tar -xzf pf3.3b1.tar.gz
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
tar -xzf pf3.3b2.tar.gz

# Check for dependencies and install them if necessary
cd phyloFlash-pf3.3b1
cd phyloFlash-pf3.3b2
./phyloFlash.pl -check_env
```

Expand Down
4 changes: 2 additions & 2 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ If you clone the repository directly off GitHub you might end up with a version

```bash
# Download latest release
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
tar -xzf pf3.3b1.tar.gz
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
tar -xzf pf3.3b2.tar.gz
```

Alternatively clone the latest development version with Git:
Expand Down
12 changes: 9 additions & 3 deletions phyloFlash_makedb.pl
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ =head2 INPUT FILES
This should be the Fasta-formatted SILVA SSURef file, clustered at 99% identity,
with SILVA taxonomy strings in file header, and sequences truncated to SSU gene
boundaries. The file name should be in the form
I<SILVA_[Release]_SSURef_Nr99_tax_silva_trunc.fasta.gz>
I<SILVA_[Release]_SSURef_Nr99_tax_silva_trunc.fasta.gz> (release 132 and before) or
I<SILVA_[Release]_SSURef_NR99_tax_silva_trunc.fasta.gz> (from release 138 onwards)
=item --univec_file F<path/to/univec_db>
Expand Down Expand Up @@ -172,9 +173,10 @@ =head1 COPYRIGHT AND LICENSE
use Cwd;
use Storable;
use File::Spec;
use File::Basename;

# URLS
my $silva_url = "ftp.arb-silva.de/current/Exports/*_SSURef_Nr99_tax_silva_trunc.fasta.gz";
my $silva_url = "ftp.arb-silva.de/current/Exports/*_SSURef_N?99_tax_silva_trunc.fasta.gz";
my $univec_url = "ftp.ncbi.nlm.nih.gov/pub/UniVec/UniVec";

# constants
Expand Down Expand Up @@ -252,7 +254,11 @@ =head1 COPYRIGHT AND LICENSE
}

# extract SILVA version
my ($silva_release) = ($silva_file =~ m/SILVA_([^_]+)_/);
# get file basename, in case a path is specified
my ($silva_file_filename,
$silva_file_dirs,
$silva_file_suffix) = fileparse($silva_file);
my ($silva_release) = ($silva_file_filename =~ m/SILVA_([^_]+)_/);

if (!$&) {
err("Unable to extract version from SILVA database filename:",
Expand Down

0 comments on commit 4496ff4

Please sign in to comment.