Merge pull request #176 from HPI-Information-Systems/fix/total-count-…

…calculation Fix calculation of total count
HPI-Information-Systems · May 5, 2021 · 1cd3ad5 · 1cd3ad5
2 parents 7a4e5c5 + f7698e2
commit 1cd3ad5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/app/src/pages/BinaryMetricsPage/BinaryMetricsPage.tsx b/app/src/pages/BinaryMetricsPage/BinaryMetricsPage.tsx
@@ -25,6 +25,7 @@ import { Store } from 'store/models';
 import { MetricsTuplesCategories } from 'types/MetricsTuplesCategories';
 import { TuplesLoader } from 'types/TuplesLoader';
 import { intersectionDescription } from 'utils/intersectionDescription';
+import { numberOfDistinctPairs } from 'utils/numberOfDistinctPairs';
 
 const getCountsByTuplesCategory = (
   store: Store,
@@ -118,9 +119,8 @@ const mapStateToProps = (state: Store): BinaryMetricsPageStateProps => ({
     state.BinaryMetricsStore.selectedDataView
   ),
   confusionMatrix: {
-    totalCount: Math.pow(
-      state.BenchmarkConfigurationStore.selectedDataset?.numberOfRecords ?? 0,
-      2
+    totalCount: numberOfDistinctPairs(
+      state.BenchmarkConfigurationStore.selectedDataset?.numberOfRecords ?? 0
     ),
     falseNegatives: getPairCountByTuplesCategory(
       state,

diff --git a/app/src/utils/numberOfDistinctPairs.ts b/app/src/utils/numberOfDistinctPairs.ts
@@ -0,0 +1,2 @@
+export const numberOfDistinctPairs = (size: number): number =>
+  (size * (size - 1)) / 2;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		export const numberOfDistinctPairs = (size: number): number =>
		(size * (size - 1)) / 2;