Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOR-469: Add support for gds word and character counter #204

Merged
merged 1 commit into from
Oct 28, 2024
Merged

FOR-469: Add support for gds word and character counter #204

merged 1 commit into from
Oct 28, 2024

Conversation

Rhyad-Zergane-HO
Copy link
Contributor

@Rhyad-Zergane-HO Rhyad-Zergane-HO commented Oct 18, 2024 •
edited
Loading

  • Add validator for max word count
  • Add unit tests for the max word count

@Rhyad-Zergane-HO Rhyad-Zergane-HO force-pushed the FOR-469-create-new-character-counter-using-gds-component branch from b1eda55 to 6539d1a Compare October 18, 2024 10:38
BecioProton
BecioProton approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@BecioProton BecioProton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new component looks good

@Rhyad-Zergane-HO
FOR-469: Add support for gds word and character counter
f3acefc 
* Add validator for max and min word count
@Rhyad-Zergane-HO Rhyad-Zergane-HO force-pushed the FOR-469-create-new-character-counter-using-gds-component branch from 6539d1a to f3acefc Compare October 25, 2024 09:57
@BecioProton
Copy link
Contributor

BecioProton commented Oct 28, 2024 •
edited
Loading

new component tested and proof of testing attached to the related ticket, merging now

@BecioProton BecioProton merged commit 72791d6 into master Oct 28, 2024
2 checks passed
@SamChatfield SamChatfield deleted the FOR-469-create-new-character-counter-using-gds-component branch November 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BecioProton BecioProton BecioProton approved these changes

@georgeeker georgeeker georgeeker approved these changes

@matthewdoreilly matthewdoreilly matthewdoreilly approved these changes

@msjhall138 msjhall138 msjhall138 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rhyad-Zergane-HO @BecioProton @msjhall138 @matthewdoreilly @georgeeker