Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support private (non-HL7) publication of templates #716

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ElliotSilver
Copy link

This PR removes the requirement that templates are published to the fhir.org site.

It consists of 3 changes.

  • Previously, all templates were published by HL7 from a single source tree, the publisher could enforce that templates which depended on other templates would only depend on the most recent version. A template could use the "current" version of another template, and this gets converted to the most recent specific version on publication; and reverted back after.
    Because templates published to sites other than HL7 won't have all those parent templates in the publication tree, that check isn't possible for private publication. In this PR, the check is skipped if an environment variable is set, and specific versions of parent templates must be listed.
  • The template index page makes assumptions about the site address and structure. This is made more dynamic by reading that information from package-list.json.
  • The content of the index page also includes HL7-specific text. An environment variable specifying an a file containing alternate content is now supported.

Additionally, a couple of spelling errors were corrected.

@lmckenzi
Copy link
Contributor

Why package-list.json? Isn't that replaced by publication-request.json?

@ElliotSilver
Copy link
Author

Why package-list.json? Isn't that replaced by publication-request.json?

Unless I've missed something, template publication still uses package-list.json.

@lmckenzi
Copy link
Contributor

@ElliotSilver will review for next week

@lmckenzi lmckenzi marked this pull request as draft September 10, 2024 21:12
@lmckenzi lmckenzi added the NeedGrahame Need Grahame for discussion label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedGrahame Need Grahame for discussion
Projects
Development

Successfully merging this pull request may close these issues.

2 participants