Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Replace finally statement by except BaseException to suppress all exceptions #653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Fix] Replace finally statement by except BaseException to suppress all exceptions #653

wants to merge 1 commit into from
+2 −0

Conversation

fjosw
Copy link
Collaborator

@fjosw fjosw commented Nov 3, 2024

Closes #651

@fjosw fjosw mentioned this pull request Nov 3, 2024
Open
agriyakhetarpal
agriyakhetarpal approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fjosw, I read through #651 and I think this is alright – please feel free to merge! Though, I also feel that this code wasn't written very well in the first place ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return in finally swallows exceptions
2 participants
@fjosw @agriyakhetarpal