Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust test_wrapped_name_and_docs for Python 3.13 #619

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

musicinmybrain
Copy link
Contributor

In Python 3.13, the bytecode compiler now strips indentation from docstrings; see https://docs.python.org/3.13/whatsnew/3.13.html#other-language-changes.

Rather than conditionalizing based on the interpreter version, I adjusted the test to match the docstring with or without indentation.

After this PR, all tests pass in tox -e py313. I didn’t try tox -e py313-scipy since scipy doesn’t yet publish binary wheels for Python 3.13 and it is difficult to build from source.

Copy link
Collaborator

@fjosw fjosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for contributing this fix!

@fjosw fjosw merged commit 51ae80b into HIPS:master Aug 19, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants