Stop bolding multi-line table headers by default #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraig3
force-pushed
the
tables-not-bold
branch
from
b12e2fe to
585d5fd
Compare
Really we are just removing bolds from paragraphs inside of table cells. It's a bit weird because table cells can be multi-line and single line in the same table. In this case, we just have an inconsistent table. I plan to take a 'wait and see' approach to this. Here are some examples: ```html <th>Heading 1</th> <!-- bold --> ``` ```html <th> <p>Heading 1:</p> <!-- not bold --> <p>This is the first heading</p> <!-- not bold --> </th> ``` ```html <th> Heading 1: <!-- bold --> <p><strong>Important:</strong> This is the first heading</p> <!-- bold, then not bold --> </th> ```
I've made lots of changes, so let's version the app again.
pcraig3
force-pushed
the
tables-not-bold
branch
from
585d5fd to
b569116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It used to be that we would just bold all table headings. But sometimes we have more complex table headings with several lines, typically the first line would be bold and then the ones after wouldn't be.
Here's an example:
The update in this PR is to stop bolding paragraph tags inside of table headings. Mechanically, how the app works is that we leave the content of table headings in paragraph tags if there are hard returns in there.
Here are some examples: