Create GA autodeployment file #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraig3
force-pushed
the
ga-autodeploy
branch
10 times, most recently
from
771a7fb to
ec6ea5f
Compare
pcraig3
force-pushed
the
ga-autodeploy
branch
3 times, most recently
from
c1fff08 to
ba66e29
Compare
For now this just logs us in.
pcraig3
force-pushed
the
ga-autodeploy
branch
7 times, most recently
from
da739d3 to
ecb67b3
Compare
It has a large comment block that we don't need for anything.
Also, clean up some of the print statements.
Pull the SHA from the latest commit into the app as an environment variable. The idea is that we can clearly see what version of the app is running if we insert the SHA into the HTML somewhere. Classic Paul Craig Web App™️
We aren't using this, so we don't need it.
This code is pretty ugly still but I got rid of a few lines.
Specificially, remove mentions of the HTML file, since that's not really something that we support anymore. Also make the language around Bloom coaches more general.
According to ChatGPT: > The COPY . . command in your Dockerfile should typically come right after setting the working directory and before installing dependencies to ensure that any code changes trigger a rebuild of subsequent layers. This guarantees that any changes in your application files force Docker to rerun commands that depend on them, like collectstatic.
There is some warning about how there are duplicate files being sent to the same destination, which doesn't matter to me at all. Let's just keep the pipeline that we have.
pcraig3
force-pushed
the
ga-autodeploy
branch
from
1c37a03 to
d0c61d9
Compare
pcraig3
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a GitHub Actions file to set up autodeployments to Cloud Run.
This PR works for most of the PRs we will have come through, but does not work for migrations, which are still performed manually.
This is good enough to merge though, as it will save us lots of time, and then I can reinvest some of that times to figure out this migrations step.
Also bumping the version because this is a big step for the app.