acf heading style updates #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcraig3
requested changes
Jan 2, 2025
Comment on lines
+148
to
+156
| /* Add source sans pro */ | ||
| @font-face { | ||
| font-family: "Source Sans Pro Web"; | ||
| font-style: normal; | ||
| font-weight: 600; | ||
| font-display: fallback; | ||
| src: url(/static/fonts/source-sans-pro/sourcesanspro-semibold-webfont.woff2) format("woff2"); | ||
| } | ||
|
|
There was a problem hiding this comment.
I am surprised this is there! Good find 👍
Comment on lines
+41
to
+42
| font-size: 36pt; | ||
| font-weight: 700; |
| @@ -51,9 +53,11 @@ h3 { | |||
| } | |||
|
|
|||
| h4 { | |||
| color: var(--color--cdc-blue); | |||
There was a problem hiding this comment.
Let's delete this — it gets overwritten in theme-opdiv-acf-white.css anyway.
| font-family: Source Sans Pro Web, Helvetica Neue, Helvetica, Roboto, Arial, | ||
| sans-serif; | ||
| color: var(--color--cdc-blue); | ||
| font-size: 20pt; |
There was a problem hiding this comment.
I think this is already set to 20pt in theme-base.css
| font-size: 11.5pt !important; | ||
| font-weight: 600 !important; | ||
| color: var(--color--acf-blue); |
- h4 size is already set in theme-base.css - h4 colour in theme-opdiv-acf.css is overwritten later - h7 styles don't need to be !important
From this issue: #130
pcraig3
force-pushed
the
update-acf-heading-styles
branch
from
c83ae30 to
2382562
Compare
pcraig3
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #130
Modifies headers to match new spec. h1, h4, and h7 are modified for the ACF theme
BEFORE:
AFTER:
