Solve H7 bug when importing NOFOs + extend timeout time #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, we demote heading levels vs other times we don't. When someone submits documents that have H1s in it, then we demote them all because there is only 1 H1 allowed in the document, for accesibility reasons. Historically, this has meant that we have been demoting H6 levels to H7s, which is why we shim H7s. However, when people submit a document that has H1s _and_ H7s, then it threw an exception and wouldn't import because there's no such thing as an H8. This commit solves this by keeping the H7s as H7s, it doesn't demote them but it also doesn't cause an error when they show up.
We have had trouble importing long NOFO documents in prod because the app times out. This is a test to see whether or not we can import documents with a longer timeout time. This is not the real fix, it is a temporary fix, but we want to benchmark the app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does two things:
1. Solves the import bug with H1s and H7s
Sometimes, we demote heading levels vs other times we don't.
When someone submits documents that have H1s in it, then we demote them all because there is only 1 H1 allowed in the document, for accessibility reasons.
Historically, this has meant that we have been demoting H6 levels to H7s, which is why we shim H7s.
However, when people submit a document that has H1s and H7s, then it threw an exception and wouldn't import because there's no such thing as an H8.
This commit solves this by keeping the H7s as H7s, it doesn't demote them but it also doesn't cause an error when they show up.
2. Doubles the app timeout time
We have had trouble importing long NOFO documents in prod because the app times out.
This is a test to see whether or not we can import documents with a longer timeout time.
This is not the real fix, it is a temporary fix, but we want to benchmark the app.