Make sure criterion tables are small but other step 4 tables are large #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have generic table rules that are being applied, but for step 4 we have specific expectations. Roughly speaking: - all 'criterion' tables should be small (normal col width) - all other tables in step 4 should be full-width
Also update the link to install Poetry (it was pointing to npm).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR: fixes table widths for step 4, and makes some updates to the README.
We have some general rules for table sizes:
However, for Step 4, we have more specific ideas:
This PR fixes our table rules for step 4 to make that work.
Why are we doing this
Technically a bug 🐞
How to test this
Try out CDC 0157 in the NOFO Builder and check out step 4.