Add loading gif to re-import screen + improve button loading state #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had not realized these were two separate templates. Since they use the same view, I had thought they use the same template as well.
Now the text of the button cycles through little loading dots to indicate that there is some thinking happening. This was part of my original vision for this button, so finally we have the import loading experience our users deserve.
jtmst
approved these changes
Dec 12, 2024
|
🚴 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small PR which is focused on the loading state when you are importing a NOFO.
1. Add the loading state to the re-import page
This was pointed out to me earlier today as a bug. Since #71, when you are importing a NOFO, you see a little galloping horse, but on the re-import page, nothing happens.
This is now fixed.
2. Make the button loading state more dynamic
Finally, the completion of my vision for the loading button on the import page. We now cycle through dots to indicate that it is working very hard on importing your NOFO.
This is a loading interaction for the ages.