Fixes for new DGHP document #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These new DGHP NOFOs have slightly different instructions tables headings. Here is the comment that is in the document: > Note - Most instances of “NOFO Writers” has been replaced with “New NOFO Team” as DGHP AMT populates the full Content Guide (NOFO writers/lead authors/OUs fill out the pre-NOFO). They also don't use colons, so I have removed that as well as a necessary part of the string match. Are we playing whack-a-mole with this? Maybe. Is it working so far? Yes.
So when I added the `replace_links` function, I created a bug in the `nofo_import` route. 1a891b4 Here's the bug: ```python cleaned_content = replace_chars(file_content) cleaned_content = replace_links(file_content) # bug is here: this function should be taking "cleaned_content" ``` So the `replace_chars` function was being run but not saved, which meant that we were seeing weird stuff coming back in, primarily where we see this is around the application checkboxes. Small fix to get this working again, although it took a while to find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 2 things: 1 change and 1 bugfix.
replace_charswas not being applied — now it is1. Decompose "instructions" boxes for NEW NOFO WRITERS
Content Guide documents have often have instructions for writers, explaining how to fill out the following section.
Previously, all of these boxes would be titled "Instructions for NOFO writers:", but now we are seeing a variant that goes "Instructions for new NOFO writers". Updated the function to remove these boxes as well.
2.
replace_charswas not being applied — now it isSo when I added the
replace_linksfunction (#64), I created a bug in thenofo_importroute.Here's the bug:
So the
replace_charsfunction was being run but not saved, which meant that we were seeing weird stuff coming back in, primarily where we see this is around the application checkboxes.Small fix to get this working again, although it took a while to find.
replace_charsdeals with it