[Issue #3102] Call Oauth token endpoint #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
widal001 and
andycochran
as code owners
|
@mdragon - could you look at this one again - had a merge conflict |
mdragon
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3102
Time to review: 10 mins
Changes proposed
Added a client (and mock) for calling an OAuth token endpoint
A lot of restructuring of test utils for clearer setup
Context for reviewers
https://developers.login.gov/oidc/token/
This gets the token from the OAuth server and parses the response. There is more work to do on this later as login.gov requires a special JWT to also be passed, but a basic version doesn't need that (our local mock doesn't care), so I'll follow-up on that later.
This approach to setting up a client is following some patterns I've used before that worked well. Building a mock version alongside the real one helps with testing.
Additional information
Still nothing new visually, under the hood it is just one more big step remaining to process the token