[Issue 918] Lint for print in /analytics #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDudas-Intuitial
requested review from
coilysiren,
widal001 and
acouch
as code owners
DavidDudas-Intuitial
changed the title
coilysiren
previously approved these changes
Nov 26, 2024
|
@DavidDudas-Intuitial Looks like we might need to bump the python dependencies to resolve this anchore failure: 
|
DavidDudas-Intuitial
dismissed stale reviews from widal001 and coilysiren
via
a7b7058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #918
Time to review: 1 min
Changes proposed
Removed T201 from
ignorearray inpyproject.tomlso that use of print statements will not be ignored by linter. Added exception for tests. Removed print from slack integration.Context for reviewers
Additional information