Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #1869] Removes old deliverable specs #1916

Merged
merged 3 commits into from
May 8, 2024

Conversation

widal001
Copy link
Collaborator

@widal001 widal001 commented May 3, 2024

Summary

Removes old deliverable specs that were still in documentation/deliverables/ from before we moved the deliverable drafting process into the wiki.

Fixes #1869

Time to review: 2 mins

Changes proposed

What was added, updated, or removed in this PR.

  • Deletes the documentation/deliverables/ sub-directory
  • Moves the grants protocol draft spec into the wiki sub-directory

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

Note: This also removes some of the old deliverables that weren't attached to 30k foot deliverables (e.g. communications tools, and developer tools). Do we want to preserve those old specs? Or just retire them now that we've coalesced around only creating deliverable specs for 30k deliverables?

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

These deliverables were drafted and committed before we moved the
process into the wiki
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 3, 2024
acouch
acouch previously approved these changes May 3, 2024
Copy link
Contributor

@sumiat sumiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @widal001! Where are the deliverable specifications from the public wiki living on Github? Sorry, I might have missed that! I have a couple other comments based on that response

sumiat
sumiat previously approved these changes May 6, 2024
Copy link
Contributor

@sumiat sumiat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the link: https://github.com/HHS/simpler-grants-gov/tree/main/documentation/wiki/product/deliverables! thanks for letting me know. I think this makes sense to remove the deliverables. planning for API/frontend/etc, developer tools, and communication platforms - we do have the ADRs created for those so the planning work around that is tracked. Thanks for separating out grants protocol too.

Copy link
Collaborator

@lucasmbrown-usds lucasmbrown-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@widal001 widal001 dismissed stale reviews from lucasmbrown-usds, sumiat, and acouch via 03345f7 May 8, 2024 14:21
@widal001 widal001 merged commit e801e00 into main May 8, 2024
4 checks passed
@widal001 widal001 deleted the issue-1869-remove-old-deliverables branch May 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove old deliverable specs from documentation/
4 participants