Skip to content

Commit

Permalink
[Unticketed] Upgrade Analytics code to Python 3.13 (#2894)
Browse files Browse the repository at this point in the history
## Summary

### Time to review: __3 mins__

## Changes proposed
Upgrade Analytics to Python 3.13

## Context for reviewers
The API has already done this upgrade, Python 3.13 has very few
impactful changes (mostly experimental features you need to enable).
Doing this to try to resolve some build issues I'm seeing in CI/CD,
especially regarding the renovate upgrades that are being attempted:
#1994
  • Loading branch information
chouinar authored Nov 18, 2024
1 parent 04b68bf commit defe937
Show file tree
Hide file tree
Showing 5 changed files with 1,196 additions and 1,208 deletions.
2 changes: 1 addition & 1 deletion .dockleconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# DOCKLE_ACCEPT_FILES="file1,path/to/file2,file3/path,etc"
# https://github.com/goodwithtech/dockle#accept-suspicious-environment-variables--files--file-extensions
# The apiflask/settings file is a stub file that apiflask creates, and has no sensitive data in. We are ignoring it since it is unused
DOCKLE_ACCEPT_FILES=api/.venv/lib/python3.13/site-packages/apiflask/settings.py,analytics/.venv/lib/python3.12/site-packages/jedi/settings.py
DOCKLE_ACCEPT_FILES=api/.venv/lib/python3.13/site-packages/apiflask/settings.py,analytics/.venv/lib/python3.13/site-packages/jedi/settings.py
2 changes: 1 addition & 1 deletion .github/workflows/ci-analytics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.12"
python-version: "3.13"

# install poetry
- uses: Gr1N/setup-poetry@v9
Expand Down
2 changes: 1 addition & 1 deletion analytics/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# The build stage that will be used to deploy to the various environments
# needs to be called `release` in order to integrate with the repo's
# top-level Makefile
FROM python:3.12-slim AS base
FROM python:3.13-slim AS base

# Install poetry, the package manager.
# https://python-poetry.org
Expand Down
2,395 changes: 1,191 additions & 1,204 deletions analytics/poetry.lock

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion analytics/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ pandas = "^2.0.3"
pandas-stubs = "^2.0.2.230605"
plotly = "^5.15.0"
pydantic = "^2.0.3"
python = "~3.12"
python = "~3.13"
slack-sdk = "^3.23.0"
typer = { extras = ["all"], version = "^0.9.0" }
sqlalchemy = "^2.0.30"
Expand Down Expand Up @@ -51,6 +51,7 @@ disable = [
"R0801", # duplicate-code
"W0511", # fix-me
"R0913", # too-many-arguments
"R0917", # too-many-positional-arguments
"R0902", # too-many-instance-attributes
"R0903", # too-few-public-methods
"W1514", # unspecified-encoding
Expand Down

0 comments on commit defe937

Please sign in to comment.