Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds CAN budget form #3212

Merged
merged 13 commits into from
Dec 19, 2024
Merged

feat: adds CAN budget form #3212

merged 13 commits into from
Dec 19, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Dec 11, 2024

What changed

  • adds CAN budget form

Issue

#310 #3099

How to test

  1. e2e tests pass
  2. logging in as budget team
  3. goto CANs details Funding Budget /cans/504/funding
  4. select current fiscal year from drop down
  5. enter edit mode via edit button
  6. enter Budget Amount into input
  7. click on Add FY Budget button
  8. see value populate the card on the right FY CAN Budget Card
  9. click on Save Changes button
  10. see results on CAN Funding page

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@fpigeonjr fpigeonjr changed the title feat: adds can budget form feat: adds CAN budget form Dec 17, 2024
headers: { "Content-Type": "application/json" },
body: data
}),
invalidatesTags: ["Cans"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will want to add CanFunding tag to this list. That way when you update the funding the getCanFundingSummary will re-fetch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@maiyerlee maiyerlee merged commit 1bf6b5c into main Dec 19, 2024
42 checks passed
@maiyerlee maiyerlee deleted the OPS-310/3099_CAN_budget_form branch December 19, 2024 17:48
Copy link

🎉 This PR is included in version 1.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants