feat: ✨adds pagination to Can Budget Lines #3078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set pagination to 3 to be able to test. probably want to set to 25 in prod
fpigeonjr
changed the title
fpigeonjr
changed the title
fpigeonjr
requested review from
jonnalley,
johndeange,
rajohnson90,
devops-chris,
maiyerlee and
Santi-3rd
johndeange
approved these changes
Nov 14, 2024
…to OPS-2672/3053_pagination
fpigeonjr
commented
Nov 15, 2024
| ))} | ||
| </Table> | ||
| {budgetLines.length > ITEMS_PER_PAGE && ( | ||
| <PaginationNav |
fpigeonjr
commented
Nov 15, 2024
| * @param {CANFundingInfoCard} props | ||
| * @returns {JSX.Element} - The component JSX. | ||
| */ | ||
| const CANFundingInfoCard = ({ funding, fiscalYear }) => { |
There was a problem hiding this comment.
didn't mean to include this but here we are
fpigeonjr
commented
Nov 15, 2024
| @@ -66,16 +66,18 @@ export type FundingBudget = { | |||
| }; | |||
|
|
|||
| export type FundingDetails = { | |||
| active_period?: number; | |||
There was a problem hiding this comment.
@rajohnson90 you may want to check the schema since I don't see these additions in the OpenAPI spec
rajohnson90
approved these changes
Nov 15, 2024
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Issue
#2672 #3053
How to test
Screenshots
Definition of Done Checklist