Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: attempt to use node for dependency rather than bun #3063

Merged
merged 2 commits into from
Nov 12, 2024
Merged

build: attempt to use node for dependency rather than bun #3063

merged 2 commits into from
Nov 12, 2024

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Nov 12, 2024 •
edited
Loading

What changed

Bun does not seem to work well with semantic-release - attempt to use Node instead

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

jonnalley
jonnalley approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jonnalley jonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 😞

@johndeange johndeange merged commit 370786a into main Nov 12, 2024
43 checks passed
@johndeange johndeange deleted the node-semantic-release branch November 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@jonnalley jonnalley jonnalley approved these changes

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@johndeange johndeange

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johndeange @jonnalley @fpigeonjr