Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds CAN Cards on Spending Tab #3051

Merged
merged 43 commits into from
Nov 14, 2024
Merged

feat: ✨ adds CAN Cards on Spending Tab #3051

merged 43 commits into from
Nov 14, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Nov 8, 2024 •
edited
Loading

What changed

  • adds CAN Cars on spending tab
  • agreement data is hard-coded for now

Issue

#2672 #3046

How to test

  1. goto cans list
  2. select 2021 from fy filter
  3. select CAN 4426
  4. goto spending tab
  5. select 2043 from fy filter
  6. see cards update

Screenshots

image

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Nov 8, 2024
@fpigeonjr fpigeonjr changed the title Ops 2672/cards wip: CAN Cards on Spending Tab Nov 8, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Nov 8, 2024
@fpigeonjr fpigeonjr changed the title wip: CAN Cards on Spending Tab feat: ✨ adds CAN Cards on Spending Tab Nov 13, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review November 13, 2024 23:24
@fpigeonjr fpigeonjr merged commit bba5da3 into main Nov 14, 2024
42 checks passed
@fpigeonjr fpigeonjr deleted the OPS-2672/cards branch November 14, 2024 17:57
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange johndeange approved these changes

@jonnalley jonnalley Awaiting requested review from jonnalley

@devops-chris devops-chris Awaiting requested review from devops-chris

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fpigeonjr @johndeange @rajohnson90