Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman issues #3033

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Podman issues #3033

merged 5 commits into from
Nov 12, 2024

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Nov 6, 2024

What changed

Changes needed to get podman working on my M3 Mac (podman is required by Flexion)

  • Update docker-compose.yml files to be platform independent
  • Separate docker-compose.yml profiles into separate files
  • Use --production dependencies in FE Dockerfile (same as production)

How to test

Compose still works and automated tests pass.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@johndeange johndeange marked this pull request as ready for review November 6, 2024 18:24
@fpigeonjr
Copy link
Contributor

how did you get around the pre-commit hook as seen here:

https://github.com/HHS/OPRE-OPS/pull/3029/files#r1830201896

Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to get the app running with podman but don't think we want the prod flag for localdev since it effects the tooling:

podman compose -f docker-compose.static.yml up --build

@fpigeonjr
Copy link
Contributor

Was able to get the app running with podman but don't think we want the prod flag for localdev since it effects the tooling:

podman compose -f docker-compose.static.yml up --build

disregard was running wrong command 🙃

@johndeange johndeange merged commit bb15d50 into main Nov 12, 2024
43 checks passed
@johndeange johndeange deleted the podman-issues branch November 12, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants