Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops 2662 can migration 2 #2945

Merged
merged 13 commits into from
Oct 21, 2024
Merged

Ops 2662 can migration 2 #2945

merged 13 commits into from
Oct 21, 2024

Conversation

johndeange
Copy link
Contributor

@johndeange johndeange commented Oct 17, 2024

What changed

  • Prototype of downloading blob to Container App Job using user managed identity credentials.
  • Also pinging DB from Container App Job
  • Decode TSV test CANs file.
  • Added helper scripts for creating common resources using Azure CLI.

N.B. This is the second pass and is still a work in progress. The Terraform will need to be added based on the scripts. The next step is to translate the decoded TSV file in SQLAlchemy model instances.

Azure log of successful run:
query_data.csv

Issue

#2654
#2662

How to test

Automated tests pass.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 tests pass but will defer to others

@johndeange johndeange merged commit f0b9c2b into main Oct 21, 2024
40 checks passed
@johndeange johndeange deleted the OPS-2662-can-migration-2 branch October 21, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants