-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ops 2662 can migration 2 #2945
Merged
Merged
Ops 2662 can migration 2 #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to Azure Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
# Conflicts: # backend/data_tools/Pipfile.lock
Signed-off-by: John DeAngelis <[email protected]>
johndeange
requested review from
rajohnson90,
fpigeonjr,
devops-chris,
maiyerlee and
Santi-3rd
October 17, 2024 14:15
maiyerlee
approved these changes
Oct 17, 2024
fpigeonjr
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 tests pass but will defer to others
Santi-3rd
approved these changes
Oct 17, 2024
# Conflicts: # backend/data_tools/Pipfile.lock
Signed-off-by: John DeAngelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
N.B. This is the second pass and is still a work in progress. The Terraform will need to be added based on the scripts. The next step is to translate the decoded TSV file in SQLAlchemy model instances.
Azure log of successful run:
query_data.csv
Issue
#2654
#2662
How to test
Automated tests pass.
Definition of Done Checklist