-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable user accounts script #2898
Disable user accounts script #2898
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @maiyerlee but will defer to others. Glad we have this feature now.
@@ -0,0 +1,67 @@ | |||
# 26. Container Apps Jobs for Disabling Inactive Users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ thx for adding the ADR
" WHERE ou.status = 'ACTIVE' " | ||
" AND user_session.last_active_at < CURRENT_TIMESTAMP - INTERVAL '60 days'" | ||
");" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there it is!
@@ -0,0 +1,25 @@ | |||
EXCLUDED_USER_IDS = [520, 521, 522, 523, 525, 526] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These user ids will only reference fake users in lower environments - in PROD these will be real users. It would be better to use the oidc ids here to reference them. Same for the SYSTEM_USER_ID
- that will only be the correct id in lower environments where test data is being loaded.
What changed
Issue
#2756
How to test
ops_user
table.Verify unit and e2e tests pass.
Screenshots
N/A
Definition of Done Checklist
Links
N/A