Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint for CANFundingBudgets #2854

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Conversation

rajohnson90
Copy link
Contributor

What changed

This PR adds the endpoints for /can-funding-budgets/ and allows the creation, update, and deletion of those objects within our database. In addition

Issue

OPS-2837

How to test

Run backend python tests. There are no front end tests to run because this endpoint is not being consumed yet until we add the funding budget workflow.

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

fpigeonjr and others added 2 commits September 23, 2024 15:04
… fixing some extraneous variable creation in unit tests and bad comments/messages in /cans/ api endpoints.
@rajohnson90 rajohnson90 added task task for an associated story or backlog item tech-debt Resolved technical debt (tooling, configuration, or workflow) python Pull requests that update Python code Dev Backend Ready Backend, Pipeline, or other UX related work is refined, and ready for Developers labels Sep 25, 2024
@rajohnson90 rajohnson90 self-assigned this Sep 25, 2024
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 tests pass but will defer to others

frontend/src/pages/agreements/approve/ApproveAgreement.jsx Outdated Show resolved Hide resolved
backend/ops_api/ops/schemas/cans.py Show resolved Hide resolved
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

think we fixed this together on #2846

@rajohnson90
Copy link
Contributor Author

I can't respond to Frank directly for some reason, but I imagine that will be fixed once your change is merged in.

@fpigeonjr
Copy link
Contributor

merged in #2846 to main @rajohnson90 so it should resolve the openApi issue

@fpigeonjr fpigeonjr self-requested a review September 27, 2024 21:56
@fpigeonjr fpigeonjr dismissed their stale review September 30, 2024 14:47

OpenApi spec looks good now

@rajohnson90 rajohnson90 merged commit 465af7a into main Sep 30, 2024
40 checks passed
@rajohnson90 rajohnson90 deleted the OPS-2837/can-funding-budget branch September 30, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Backend Ready Backend, Pipeline, or other UX related work is refined, and ready for Developers python Pull requests that update Python code task task for an associated story or backlog item tech-debt Resolved technical debt (tooling, configuration, or workflow)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants