Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🛠️ adds missing validation on Agreement form #2832

Merged
merged 5 commits into from
Sep 24, 2024
Merged

fix: 🛠️ adds missing validation on Agreement form #2832

merged 5 commits into from
Sep 24, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Sep 20, 2024 •
edited
Loading

What changed

  • adds missing Vest validation

Issue

#2770

How to test

  1. create min agreement
  2. try to send to review
  3. see validation errors
  4. go to edit to fix errors
  5. they should match
  6. 💰 profit

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@fpigeonjr fpigeonjr self-assigned this Sep 20, 2024
@fpigeonjr fpigeonjr added bug Something isn't working javascript Pull requests that update Javascript code labels Sep 20, 2024
@fpigeonjr fpigeonjr changed the title fix: 🛠️ fixes validation issues fix: 🛠️ adds missing validation on Agreement form Sep 20, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review September 20, 2024 20:37
@jonnalley
Copy link
Contributor

Given this is a bug, is there an opportunity to update our tests?

@fpigeonjr fpigeonjr merged commit 4a20a8f into main Sep 24, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-2770/validation_fix branch September 24, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@johndeange johndeange johndeange approved these changes

@devops-chris devops-chris Awaiting requested review from devops-chris

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

@npage123 npage123 Awaiting requested review from npage123

Assignees

@fpigeonjr fpigeonjr

Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fpigeonjr @jonnalley @johndeange @rajohnson90