Ops 441 initial page and combobox #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
# Conflicts: # frontend/src/tests/data.js
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
Signed-off-by: John DeAngelis <[email protected]>
johndeange
requested review from
rajohnson90,
fpigeonjr,
devops-chris and
maiyerlee
|
👀 |
When logged in as as Director Dave, I am not seeing the User Admin tab 
When I login as Budget Team, then I see the User Admin tab 
|
|
🥇 UserInfo is only editable by the Budget Team 
|
fpigeonjr
reviewed
Aug 7, 2024
| const [selectedRoles, setSelectedRoles] = React.useState([]); | ||
| const statusData = [ | ||
| { id: 1, name: "ACTIVE" }, | ||
| { id: 2, name: "INACTIVE" }, |
There was a problem hiding this comment.
ACTIVE, INACTIVE, LOCKED would be a good use-case for an ENUM
fpigeonjr
reviewed
Aug 7, 2024
| const { data: divisions, error: errorDivisions, isLoading: isLoadingDivisions } = useGetDivisionsQuery(); | ||
| const { data: roles, error: errorRoles, isLoading: isLoadingRoles } = useGetRolesQuery(); | ||
|
|
||
| useEffect(() => { |
fpigeonjr
reviewed
Aug 7, 2024
|
|
||
| .centeredItem { | ||
| align-items: center; | ||
| display: flex; |
There was a problem hiding this comment.
may be able to use USWDS classes here like: "display-flex, flex-align-center"?
fpigeonjr
requested changes
Aug 7, 2024
|
I apologize @fpigeonjr , I messed up the "How to Test" section. You are correct that the test user with the |
maiyerlee
approved these changes
Aug 8, 2024
fpigeonjr
approved these changes
Aug 8, 2024
fpigeonjr
reviewed
Aug 8, 2024
| * @property {string} INACTIVE - Represents an inactive status for a user. | ||
| * @property {string} LOCKED - Represents a locked status for a user. | ||
| */ | ||
| export const USER_STATUS = { |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
User Adminpage (only accessible by users with theUSER_ADMINrole)Budget Teamuser with rolesBUDGET_TEAMandUSER_ADMINUserInfocomponent to make editable byUSER_ADMIN(and display human readable values)opsAuthAPImswJS stub (mocks.js)Issue
#441
How to test
USER_ADMINrole can access theUser Adminmenu optionAdminand the menu option should not be visible.Budget Teamand the option should be visible (since BT is aUSER_ADMIN)USER_ADMINhas an editable view ofUserInfoLogin as
Admin(or any user other thanBudget Team)Click on the user's email address in the upper right of the page to go to the
User Detailspage.Verify that the
UserInfois read-only.Login as
Budget TeamClick on the user's email address in the upper right of the page to go to the
User Detailspage.Verify that the
UserInfois editable, i.e. has combo boxes for status, role, and divisionN.B. The actual persistence of the
UserInfochanges will be covered in a future PR. (There is already too much going on in this PR)Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist