Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: current project officer not being selected in edit form #1539

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

stevtek
Copy link
Contributor

@stevtek stevtek commented Oct 3, 2023

What changed

fix for the the project officer combo box being empty when edit an agreement with a project

NOTE: this removes code which says that it's a workaround for a caching problem, but I can't replicate that now

Issue

#1537

How to test

  • edit an agreement which already has a project officer, the project officer combobox should be populated with that

Screenshots

If relevant, e.g. for a front-end feature

Definition of Done Checklist

  • [ ] OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [ ] Form validations updated

Links

If relevant, e.g. for a link to a piece of markdown documentation

@stevtek stevtek marked this pull request as ready for review October 4, 2023 14:42
@stevtek stevtek merged commit 58bf355 into main Oct 4, 2023
9 checks passed
@stevtek stevtek deleted the OPS-1537-Fix-project-officer-in-edit-form branch October 4, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants