[TTAHUB-3437] Modals should be immediately after the control that spawned them #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewatermethod
requested review from
nvms,
GarrettEHill,
kryswisnaskas,
AdamAdHocTeam,
hpeasley and
hardwarehuman
and removed request for
hpeasley
| @@ -260,12 +251,22 @@ function EventCard({ | |||
| <p className="usa-prose margin-y-0">{checkForDate(data.endDate)}</p> | |||
| </div> | |||
| <div className="ttahub-event-card__event-column ttahub-event-card__event-column__menu position-absolute right-0"> | |||
| {true && ( | |||
There was a problem hiding this comment.
Was this hard coded ....
nvms
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Move some modals near their triggers. A few remain in the app that aren't inline. I will itemize these in another Jira for a larger refactor.
How to test
Confirm that you can still unlock reports, change an objective's status from the RTR, and delete an event from the training report landing page.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy