-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prod] Properly track eventSubmitted, updates to Slack message around PR deploys #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test post-merge extraction
Remove PR_TITLE
Test deployment message
[TTAHUB-3336] Extract PR number for deployment completion slack notification.
thewatermethod
changed the title
[Prod] Properly track "eventSubmitted," updates to Slack message around PR deploys
[Prod] Properly track eventSubmitted, updates to Slack message around PR deploys
Aug 30, 2024
hpeasley
approved these changes
Aug 30, 2024
Merging since this PR is time sensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We need to capture the "eventSubmitted" variable in the data of a Training Report when the owner submits it. The "complete event" functionality depends on it. It seems to have been removed as part of a bug squash in the days leading up to the TR release.
This PR also includes code to further customize the slack message deployments.
How to test
Impersonating the user in this slack thread, confirm that you can submit and then complete the event in question
Alternately, confirm "eventSubmitted" is present in the request body when submitting a training report. A unit test has been added to validate this specific field.
Issue(s)
Checklists
Every PR
Before merge to main
Production Deploy
After merge/deploy