Planning refactor #202
Merged
Planning refactor #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update planRec
…the end of the simulation.
…opped setXId() methods in the plans since there is already package access. Changed Plan constructor to package access to avoid confusion. Added getArrivalId() method on the Plan to facilitate serialization of descendant types.
…the planning system.
…he plan queue before new plans scheduled for the same time. Both recovered and new plans execute in the proper order.
bischoffz
added a commit
that referenced
this pull request
Feb 28, 2024
* remove plan conversion mechinisms * remove plan.key * remove prioritized plan data * remove plandata * refactor plan * create subplans update planRec * clean up * remove at_plan * remove at_priortizedplandata * remove planqueue data * remove nucleus errors used in planqueuedata * clean up simstate comments * set masterarrivalid to -1 * add planing queue mode logic to addPlan * rebuild planning queue before chaning state * drop planrec toString * remove planrec.planner * remove planrec arrival id * remove planrec time * remove planRec isactive * remove planrec type fields * replace planRec with plan * clean up * cancel mekanism * safer casting * clean up * clean up * fix test * clean up * clean up * Added access to retrieved plans * Fixed rebuild of plan queue. Added plan retrieval mechanism. * Added suggested constructors for plans * Added new nucleus error to handle plan retrievals that happen before the end of the simulation. * slight refactor of rebuildPlanQueue * remove plansRequirePlanData * arrivalId fix * Changed arrival id inputs from -1 to -1L since it is a long value. Dropped setXId() methods in the plans since there is already package access. Changed Plan constructor to package access to avoid confusion. Added getArrivalId() method on the Plan to facilitate serialization of descendant types. * Adapting the gcm lessons to the changes in the planning system * Updated actor, dataManager and report contexts to reflect changes in the planning system. * Added simple test that demonstrates recovered plans are executed in the plan queue before new plans scheduled for the same time. Both recovered and new plans execute in the proper order. * add tests for plans * remove OBE test * add tests for retrievePlans --------- Co-authored-by: shawnhatch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.