Update istanbul asset files #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suite800
reviewed
Apr 17, 2019
| }; | ||
| }()); | ||
| })(); |
| var missingCoverageClasses = [ '.cbranch-no', '.cstat-no', '.fstat-no' ]; | ||
| var jumpToCode = (function init() { | ||
| // Classes of code we would like to highlight in the file view | ||
| var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no']; |
There was a problem hiding this comment.
Here the indentation looks to be 2 spaces, whereas further down they are 4. If it’s not a huge effort, it’d be good to be consistent.
|
@suite800 Both suggestions make sense to me, but since this file is just copied straight from the upstream library, I'm hesitant to make any changes at all. (I'd rather it be identical, so that when I update it again a year or 10 years from now, the diff I'm seeing is just what changed in the upstream repo). |
|
This fell through the crack and I just noticed it. Sorry Elliot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Pull in the latest asset files from the istanbul/nyc project for our istanbul fork.
DETAILS
No breaking changes here. Mostly I'm just pulling in the change I made upstream earlier this year (istanbuljs/istanbuljs#265), which adds the keyboard shortcuts to the file listing view in addition to the in-file view.