Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few blocking/callback issues in the vault API #1486

Merged
merged 7 commits into from
Sep 19, 2023
Merged

Fix a few blocking/callback issues in the vault API #1486

merged 7 commits into from
Sep 19, 2023

Commits on Sep 16, 2023

  1. Remove unused blocking ptVault.sendToDevice/VaultPublishNode

    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9cce806 View commit details
    Browse the repository at this point in the history

  2. Make VaultAgeSetDeviceInbox non-blocking

    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a141185 View commit details
    Browse the repository at this point in the history

  3. Make VaultAgeAddDevice non-blocking

    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    c2ed4b0 View commit details
    Browse the repository at this point in the history

  4. Remove unused blocking variants of VaultAgeFindOrCreate*AgeLink

    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    97bd41b View commit details
    Browse the repository at this point in the history

  5. Rename vault functions that were called ...AndWait despite not blocking

    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    a6fa60e View commit details
    Browse the repository at this point in the history

  6. Remove unused callbacks from PtCreatePublicAge/PtRemovePublicAge 

    These callback parameters were ignored and no Python code defined a
publicAgeCreated or publicAgeRemoved method. The public/private change
notification is actually delivered as a plVaultNotifyMsg with type
kPublicAgeCreated or kPublicAgeRemoved sent by VaultSetAgePublic.
    @dgelessus
    dgelessus committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9b8523c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Fix nb01DRCImager not using ptAgeVault.addDevice callback correctly

    @dgelessus
    dgelessus committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    30777dc View commit details
    Browse the repository at this point in the history