Skip to content

Commit

Permalink
Allowing Github Actions to handle zipping
Browse files Browse the repository at this point in the history
There be dragons here. We originally kept Github Actions from performing the zip because our archive had symlinks in it, which it turns into hard copes of files. Xcode's archive and code signing tooling expects those symlinks, so we weren't able to sign.

As of right now - there are no symlinks in the archive. So things should be ok. If any frameworks are added this will break again. Hopefully by that point Github has resolved their issues.
  • Loading branch information
colincornaby committed Aug 13, 2023
1 parent 8db844b commit 7a83085
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,9 @@ jobs:
- name: Install
run: |
cmake --build build --target install --config "${{ matrix.cfg.type }}" -j 2
cd build/install
zip -y -r ../../plasma-${{ matrix.platform.str }}-${{ matrix.cfg.str }}.zip *
- name: Upload Artifacts
uses: actions/upload-artifact@v3
with:
name: plasma-${{ matrix.platform.str }}-${{ matrix.cfg.str }}
path: plasma-${{ matrix.platform.str }}-${{ matrix.cfg.str }}.zip
path: build/install

0 comments on commit 7a83085

Please sign in to comment.