Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding french translation #64

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Adding french translation #64

merged 1 commit into from
Feb 8, 2023

Conversation

acolombier
Copy link
Contributor

Answering to the call in the issue #60, this PR adds translation for french.

Worth to mention that although native speaker, it has been a few years I have written my own language in a formal way, so if there is any fellow french speakers that could help review it, that would be massively appreciated!

@acolombier acolombier mentioned this pull request Feb 8, 2023
Open
@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2023

That's amazing!
If you know other French people you could ask directly to them to give it a look. However, if you speak French don't worry too much about the level of formalism, your translation will be surely good enough!

@acolombier acolombier marked this pull request as ready for review February 8, 2023 11:38
GyulyVGC
GyulyVGC reviewed Feb 8, 2023
View reviewed changes
Copy link
Owner

@GyulyVGC GyulyVGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about French, but it seems to me that the last phrase refers to "minutes" instead of "notifications"

@acolombier
Copy link
Contributor Author

You're correct - thanks for catching that! Should be updated now.

@GyulyVGC
Copy link
Owner

GyulyVGC commented Feb 8, 2023

Thanks a lot for the translation, now all checks pass and everything seems good.
I will do the last graphical checks on the GUI and then the PR will be merged.

@GyulyVGC GyulyVGC merged commit ab5e9f7 into GyulyVGC:main Feb 8, 2023
Katew212
Katew212 reviewed Feb 27, 2023
View reviewed changes
Copy link

@Katew212 Katew212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

@GyulyVGC GyulyVGC added the translation User interface translation label Mar 27, 2023
GyulyVGC added a commit that referenced this pull request May 7, 2023
@GyulyVGC
Merge pull request #64 from acolombier/feat/french-translation
a1b9980 
Adding french translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katew212 Katew212 Katew212 left review comments

@GyulyVGC GyulyVGC Awaiting requested review from GyulyVGC

Assignees
No one assigned
Labels
translation User interface translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acolombier @GyulyVGC @Katew212