Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support on demand access #26

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yair-develeap
Copy link

@yair-develeap yair-develeap commented Dec 2, 2024

Support OnDemandAccess --> see api: https://help.tableau.com/current/api/rest_api/en-us/REST/rest_api_ref_users_and_groups.htm#create_group

Disable MinimumSiteRole requirement .. as it is optional .

tested locally using filesystem_mirror . and it works as it should .

@yair-develeap
Copy link
Author

Hi @GtheSheep any updates on this PR ?

@GtheSheep
Copy link
Owner

Hi @GtheSheep any updates on this PR ?

Will take a look this afternoon! thanks

@GtheSheep
Copy link
Owner

@yair-develeap seems reasonable! Thanks for putting this up! 🙌
Could you please:

  • Run make fmt to format
  • Run make doc to add the new flag to the site docs
  • Add a basic test case for this flag/ it's intended use into group_resource_test.go
    Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants