Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : MySQL Interfacing #10

Merged
merged 5 commits into from
May 15, 2022
Merged

Feature : MySQL Interfacing #10

merged 5 commits into from
May 15, 2022

Conversation

tamilpp25
Copy link

@tamilpp25 tamilpp25 commented May 15, 2022

Feature : MySQL Interface

IMySQL feature

Changes made

  • Added MySQL connection
  • Works with HikariCP connection pool

How does the solution address the problem

This PR will add MySQL interface to the core plugin. To access the MySQL object you can get it from the main instance of the class. You can also make your own instance of MySQL HikariCP pool by doing new MySQL() with connection credentials! This plugin still needs to be checked with mysql.

Linked issues

Resolves #1

@tamilpp25 tamilpp25 changed the title Feature mysql interface Feature : MySQL Interfacing May 15, 2022
Copy link
Member

@Wyzards Wyzards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wyzards Wyzards merged commit 2a0161e into Grubnest:development May 15, 2022
@Wyzards Wyzards deleted the feature-mysql-interface branch May 15, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants