fix(Angular): fixed applying custom tabIndex and ariaLabel #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bar-content-wrapper
|
@Grsmto hey, could you, please, review it? |
|
@skrappyzz sure it's in my TODO - I'll take a look asap! I know it's a very small PR but I want to make sure to do a release at the same time, so it takes me a bit of time 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that setting
tabIndexandariaLabeldoesn't work as expected in Angular.tabIndexandariaLabelalways have their default values. To resolve this, the assignment ofariaLabelandtabIndexshould be moved inside thengOnInitmethod, as the constructor is called before the component is fully initialized.At that point,
this.optionsis still an empty object, rather than the options passed from the outside via the@Inputparameter.