Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Stocking Input Bus + Advanced Stocking Input Hatch #2367

Merged
merged 26 commits into from
Mar 3, 2024

Conversation

serenibyss
Copy link
Member

@serenibyss serenibyss commented Jan 30, 2024

Names tentative, recipes not yet done, blocks need new textures, and I might've forgor lang. But these should be functionally complete, and are in need of lots of testing. Excerpt from discord:

The new bus and hatch don't actually store items/fluids, instead they displays them in the UI, and then on extract call on the handler, it pulls straight out of the ME net. It has an extra mode, auto-pull, which allows its config slots to automatically update to whatever happens to be on the attached net.

Dupes are possible with this approach, since there is a widening between querying if an item is available and actually extracting the item from the network. I have combated dupes with these approaches:

  • A single bus/hatch can never have the same item/fluid configured in multiple slots
  • A bus/hatch cannot have any configured items/fluids that match other advanced stocking parts on the same multiblock. For items, this is only applied when distinct buses is disabled, as if it is enabled, the recipe lookup is fully separated between parts. For fluids, this is always enabled since there is no notion of distinct fluid inputs.

This PR also adds extra features to both the old and the new stocking item bus:

  • Ghost circuit slot
  • Extra storage slot, meant for a mold, lens, or some other not-consumed item required for a recipe.

Additionally I reworked the UI of all 4 hatches, and significantly refactored the original stocking bus/hatch code.

This PR also contains #2358 in it currently, because without it they do not function at all (items + fluids are never properly extracted from the network). So that PR is required to merge before this one, at which point I'll rebase it off of new master.

@serenibyss serenibyss added the type: feature New feature or request label Jan 30, 2024
@serenibyss serenibyss requested a review from a team as a code owner January 30, 2024 05:52
@serenibyss serenibyss merged commit db174d2 into master Mar 3, 2024
3 checks passed
@serenibyss serenibyss deleted the sb-adv-stocking-bus-hatch branch March 3, 2024 22:14
ALongStringOfNumbers pushed a commit that referenced this pull request Apr 24, 2024
ALongStringOfNumbers pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants