-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Stocking Input Bus + Advanced Stocking Input Hatch #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
force-pushed
the
sb-adv-stocking-bus-hatch
branch
from
January 31, 2024 03:20
1e3ca00
to
60fd04b
Compare
serenibyss
force-pushed
the
sb-adv-stocking-bus-hatch
branch
from
January 31, 2024 03:26
60fd04b
to
93f3a39
Compare
TechLord22
reviewed
Mar 2, 2024
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Show resolved
Hide resolved
.../gregtech/common/metatileentities/multi/multiblockpart/appeng/slot/ExportOnlyAEItemSlot.java
Show resolved
Hide resolved
...a/gregtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEInputBus.java
Show resolved
Hide resolved
...regtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEStockingBus.java
Outdated
Show resolved
Hide resolved
...gtech/common/metatileentities/multi/multiblockpart/appeng/MetaTileEntityMEStockingHatch.java
Outdated
Show resolved
Hide resolved
TechLord22
approved these changes
Mar 3, 2024
ALongStringOfNumbers
pushed a commit
that referenced
this pull request
Apr 24, 2024
(cherry picked from commit db174d2)
ALongStringOfNumbers
pushed a commit
that referenced
this pull request
May 7, 2024
(cherry picked from commit db174d2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names tentative, recipes not yet done, blocks need new textures, and I might've forgor lang.But these should be functionally complete, and are in need of lots of testing. Excerpt from discord:The new bus and hatch don't actually store items/fluids, instead they displays them in the UI, and then on extract call on the handler, it pulls straight out of the ME net. It has an extra mode, auto-pull, which allows its config slots to automatically update to whatever happens to be on the attached net.
Dupes are possible with this approach, since there is a widening between querying if an item is available and actually extracting the item from the network. I have combated dupes with these approaches:
This PR also adds extra features to both the old and the new stocking item bus:
Additionally I reworked the UI of all 4 hatches, and significantly refactored the original stocking bus/hatch code.
This PR also contains #2358 in it currently, because without it they do not function at all (items + fluids are never properly extracted from the network). So that PR is required to merge before this one, at which point I'll rebase it off of new master.