Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chisel module #2290

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Chisel module #2290

merged 4 commits into from
Dec 15, 2023

Conversation

serenibyss
Copy link
Member

  • New chisel groups for Warning Signs, Studs, Metal Sheets, Large Metal Sheets
  • Added to chisel groups for Marble, Basalt, Black Granite, Red Granite (all 4 excluding cobblestones, since these are world-genned), Light Concrete, Dark Concrete
  • Added GT treated wood to IE treated wood chisel group if the group exists
  • Adds another oredict onto Coke Block to make it fit into the chisel coal coke group

@serenibyss serenibyss requested review from a team as code owners December 13, 2023 03:17
@serenibyss serenibyss added the type: feature New feature or request label Dec 13, 2023
Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading up in Dev, I found a couple more possibilities.

There is a Certus Quartz group that is created (I think if AE is present), we could add our block of certus quartz to that group.

Also Block of Aluminium (different spellings on the oredicts probably)

Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this, because my suggestions are not blocking, but it could be nice if they were completed

@serenibyss serenibyss merged commit 673be5b into master Dec 15, 2023
4 checks passed
@serenibyss serenibyss deleted the sb-chisel-module branch December 15, 2023 03:42
serenibyss added a commit that referenced this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants