An RTL change #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregAC
force-pushed
the
master
branch
2 times, most recently
from
d9bfafc to
2585e30
Compare
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn_core.sv |
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn.sv |
GregAC
force-pushed
the
gh_action_test
branch
4 times, most recently
from
fe0e278 to
265ea85
Compare
GregAC
force-pushed
the
master
branch
2 times, most recently
from
934dec8 to
cf05dff
Compare
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn_core.sv |
GregAC
force-pushed
the
gh_action_test
branch
2 times, most recently
from
69aad2c to
395a3f1
Compare
|
CHANGE AUTHORIZED: hw/ip/otbn/rtl/otbn.sv |
GregAC
force-pushed
the
master
branch
2 times, most recently
from
8ce0eb3 to
b35903e
Compare
GregAC
force-pushed
the
master
branch
2 times, most recently
from
4b2ed08 to
0d0ae1e
Compare
This adds a github action which checks if any changes in a PR match a list of patterns in BLOCKFILE. If there are matches the action fails which can be used to block the PR from being merged. Anyone on the COMMITTERS list can authorize a change by adding a comment with: CHANGE AUTHORIZED: path/to/file To the PR. If there are multiple changes to authorize, one authorization is required per file and there is one authorization per line in the comment. At least two committers must authorize the change to pass. Signed-off-by: Greg Chadwick <[email protected]>
GregAC
force-pushed
the
gh_action_test
branch
4 times, most recently
from
f47ef31 to
e77be47
Compare
GregAC
force-pushed
the
master
branch
2 times, most recently
from
242f5cb to
6f2a656
Compare
GregAC
pushed a commit
that referenced
this pull request
May 17, 2024
This precondition for the assertion was never possible because !state_q was never InitReq or InitAckWait. Unfortunately, fixing this makes the assertion false. It turns out that the problem was that the init_trig_i signal squashes the ping. Add a condition based on this. Annoyingly the result is very repetitive! To make things a bit tidier, move the condition into the __rst argument of the `ASSERT macro. Finally, drop the initial "##1" (which avoided the property triggering just after reset). The $rose(...) condition implies this anyway (because it's false on the first cycle after reset), so we can drop the cycle. This makes the property marginally stronger (and Jasper still proves it!) Signed-off-by: Rupert Swarbrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.