-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch retrieval of pipeline connections count on streams page. #21057
Merged
dennisoelkers
merged 10 commits into
master
from
fix/batching-pipeline-counts-retrieval
Nov 28, 2024
Merged
Batch retrieval of pipeline connections count on streams page. #21057
dennisoelkers
merged 10 commits into
master
from
fix/batching-pipeline-counts-retrieval
Nov 28, 2024
+369
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/batching-pipeline-counts-retrieval
branch
from
November 26, 2024 13:06
f313978
to
3678c98
Compare
dennisoelkers
force-pushed
the
fix/batching-pipeline-counts-retrieval
branch
from
November 26, 2024 13:13
3678c98
to
e040b2e
Compare
ousmaneo
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kodjo-anipah
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Prior to this PR, the streams page called an endpoint for each stream to retrieve the number of connected pipelines. This leads to running into the limit for concurrent requests quite fast. Also, it returns a 404 when no pipelines are connected, leading to retries and further delays.
This PR is speeding up the page by:
/nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: